Reviewable status: 0 of 3 files reviewed, 16 unresolved discussions (waiting on @janneronkko)

Reviewable status: 0 of 4 files reviewed, 17 unresolved discussions (waiting on @janneronkko)

README.md line 550 at r4 (raw file):

GRAPHQL_SECRET=
JORE3_USERNAME=
JORE3_PASSWORD=

The README.md doesn't tell what are the database preconditions for running the Python script.

Reviewable status: 0 of 4 files reviewed, 19 unresolved discussions (waiting on @culka and @janneronkko)

README.md line 542 at r4 (raw file):

By default the script runs from the local jore3 test database and uses the base local Jore4 Hasura instance as the target.
You can change the source database and target Hasura instance by creating a `.env` file in the same directory as the script.

Documentation is needed on what are the compatible versions of jore4-hasura' and other microservices. Actually, I think it would be better to make changes to the docker-compose.custom.yml` file.

README.md line 544 at r4 (raw file):

You can change the source database and target Hasura instance by creating a `.env` file in the same directory as the script.

Set the values for variables you want to set:

It is necessary to state how the data is expected to be exported to Azure. By using Azure's Hasura endpoint directly or taking a snapshot of a local database. If the latter is the case, what is the required pg_dump command?

Reviewable status: 0 of 6 files reviewed, 19 unresolved discussions (waiting on @janneronkko and @jarkkoka)

README.md line 542 at r4 (raw file):

Updated the file and startup script

README.md line 550 at r4 (raw file):

Added

Reviewed 2 of 3 files at r5, 1 of 5 files at r6.
Reviewable status: 3 of 8 files reviewed, 22 unresolved discussions (waiting on @culka and @janneronkko)

stopimport/Dockerfile line 11 at r6 (raw file):

COPY .env .

CMD ["python", "importer.py"]

Line break missing at the end

stopimport/run-stopimport.sh line 1 at r6 (raw file):

#!/usr/bin/env bash

The containing directory should be renamed from stopimport to stop_registry_import (note the underscores to improve reading) since plain "stopimport" is misleading, since the actual Java application also imports stops. We need to make it clearer what this Python application does.

In addition, I think this script should be renamed to run-stop-reg-import.sh.

stopimport/run-stopimport.sh line 3 at r6 (raw file):

#!/usr/bin/env bash

docker build -t stop-importer .

Rename stop-importer to stop-reg-importer. We need to make it clearer what this Docker container does, since the actual Java application also imports stops. We don't want to confuse new developers coming to this project in the future.

Reviewed 1 of 6 files at r7.
Reviewable status: 3 of 9 files reviewed, 24 unresolved discussions (waiting on @culka and @janneronkko)

README.md line 537 at r7 (raw file):

---

## Jore3 stop import script

Use "Jore 3" spelling here as is used consistently in this README.

README.md line 545 at r7 (raw file):

### How to use

To run the stop registry importer script you need to have a Jore3 database, a populated Jore4 routes database, Jore4 Hasura and Jore4 Tiamat running.

Let's fix the Jore spelling to be consistent with the rest of this README file.

Change this sentence to the form:

"To run the stop register importer script, you must have a Jore 3 database, a populated Jore 4 routes database, and the jore4-hasura and jore4-tiamat microservices running."

README.md line 561 at r7 (raw file):

You should have run the base Jore3 importer first which ensures the Jore4 database has the required scheduled stop points. Then run the stop registry import script which will match scheduled stop points in the Jore4 routes database with stops in the Jore3 database and generate GraphQL mutations to Hasura/Tiamat according to the data. The script will also link the generated stop registry stops with the scheduled stop points by their NeTEx ID using Hasura for the mutation.

Let's be consistent in Jore spelling with the rest of the README file:

• Jore3 => Jore 3
• Jore4 => Jore 4

Reviewable status: 3 of 9 files reviewed, 25 unresolved discussions (waiting on @culka and @janneronkko)

stop-registry-importer/importer.py line 35 at r7 (raw file):

        with conn.cursor(as_dict=True) as cursor:

            cursor.execute(f"""select * from jr_pysakki p

The SQL query does not conform to the general SQL style guide used e.g. in the jore4-hasura repository where SELECT, FROM and other such keywords are in uppercase.

Reviewable status: 3 of 9 files reviewed, 27 unresolved discussions (waiting on @culka and @janneronkko)

stop-registry-importer/importer.py line 51 at r7 (raw file):

        with conn.cursor(as_dict=True) as cursor:

            cursor.execute("""select pa.nimi, pa.pysalueid, s.sollistunnus, s.solkirjain from jr_pysakki p

For better reading, FROM should start from a new line.

stop-registry-importer/importer.py line 55 at r7 (raw file):

            inner join jr_lij_pysakkialue pa on (p.pysalueid = pa.pysalueid)
            where p.pysalueid in (
            select jp.pysalueid from jr_pysakki jp

For better reading, FROM should start from a new line

Reviewable status: 1 of 10 files reviewed, 27 unresolved discussions (waiting on @janneronkko and @jarkkoka)

README.md line 537 at r7 (raw file):

Both spellings seem to be used in this file though?

README.md line 545 at r7 (raw file):

Done.

README.md line 561 at r7 (raw file):

Done.

stopimport/Dockerfile line 11 at r6 (raw file):

There is line break at the end?